Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openbao-bin: init at 2.0.0 #337814

Closed
wants to merge 2 commits into from
Closed

openbao-bin: init at 2.0.0 #337814

wants to merge 2 commits into from

Conversation

joseph-flinn
Copy link

@joseph-flinn joseph-flinn commented Aug 27, 2024 •
edited
Loading

Description of changes

Add a pre-built binary package of OpenBao at the initial version of 2.0.0. These binaries are provided by the official OpenBao Releases (see link to official releases below). Providing packaged pre-built binaries support low-resource computers (like aarch64-linux SBCs with small disks).

Homepage: https://openbao.org
GitHub: https://github.com/openbao/openbao
Changelog: https://github.com/openbao/openbao/blob/main/CHANGELOG.md
Releases: https://github.com/openbao/openbao/releases

Related to #334485 and #300943

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Bot-wxt1221
Bot-wxt1221 reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not build from source.

@joseph-flinn
Copy link
Author

Why not build from source.

Great question! PR #334485 is open to build OpenBao from source. I ported over the work done for vault-bin.

I am currently working on a project with a low-resource aarch64 SBC that runs out of disk space when building from source. A derivation packaging the pre-built binary solved my issues. I thought I'd make the port available to work towards parity between OpenBao and Vault in the Nix ecosystem.

@Bot-wxt1221
Copy link
Member

Bot-wxt1221 commented Sep 3, 2024 •
edited
Loading

@joseph-flinn nix have cache. Build is not neccessary if have binary cache in cache.nixos.org. This package can be added to nixpkgs only if it provide different function with openbao

@joseph-flinn
Copy link
Author

Ah, that makes sense. I have personally been using this patch since openbao not yet in nixpkgs, which runs a full local compilation which is too much on the smaller SBC disks.

I'll close this PR since the NixOS cache will eventually have the binaries once #334485 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bot-wxt1221 Bot-wxt1221 Bot-wxt1221 left review comments

Assignees
No one assigned
Labels
8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-flinn @Bot-wxt1221